fix: BIP-85 test gating + --validate-junit for CI parity#186
Merged
pastaghost merged 1 commit intomasterfrom Mar 31, 2026
Merged
fix: BIP-85 test gating + --validate-junit for CI parity#186pastaghost merged 1 commit intomasterfrom
pastaghost merged 1 commit intomasterfrom
Conversation
- BIP-85 tests now skip gracefully when GetBip85Mnemonic proto is absent - New --validate-junit flag checks JUnit results against SECTIONS catalog so CI can enforce the same pass/fail rules as the PDF report
pastaghost
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
requires_message("GetBip85Mnemonic")so they skip when the proto isn't available (same pattern as Zcash/Solana/TRON tests)--validate-junitflag ongenerate-test-report.pychecks JUnit XML against SECTIONS — exits non-zero if any non-skipped test failed or is missingWhy
CI Phase 2 runs
pytest || trueand hardcodesecho "0"to the status file, so test failures never fail CI. The PDF report shows failures but nobody sees them until after merge. This flag lets the CI test job enforce the same rules as the report.Test plan
--validate-junit --junit=passing.xmlexits 0--validate-junit --junit=failing.xmlexits 1 with failure list